Release into Foxy and Eloquent? #4
Comments
|
Asking me about my feelings!? :P Yes, it's next on the radar soon as I finish the legacy pose update. Would like to do a cursory dive with it and test it out before releasing it just so I don't go and get stuck with an api promise for the rest of eloquent and foxy. Would rather like to keep an api promise for foxy since it's LTS. |
|
Are you using it in anything else? |
Actually, now that I think about it, releasing it into Rolling would be good too; that way, we'll get semi-automatic testing of it. I'm fairly sure the tests won't work on Dashing, and I haven't tried building it there anyway, so I'd just skip it. |
clalancette
added a commit
to clalancette/cmd_vel_mux
that referenced
this issue
Jan 18, 2022
**High level view** * Import the original yocs_cmd_vel_mux from https://github.com/yujinrobot/yujin_ocs/tree/devel/yocs_cmd_vel_mux * Do a bunch of cleanup on that old code * Rename yocs_cmd_vel_mux -> cmd_vel_mux * Port to ROS 2 * Make it so that parameters are much nicer * Add in tests. Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Lobotuerk <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]> **Detailed breakdown of pre-squashed commits** * Move some code around. * Rename CmdVelSubs -> CmdVelSub. * Remove yocs_ from a lot of places. * Rename yocs_cmd_vel_mux to cmd_vel_mux. * Update the package.xml to format 2. * Rename cmd_vel_mux_nodelet to cmd_vel_mux. * Remove unused FileNotFoundException. * Cleanup exception handling. * Move some code from the header to the source files. * Move implementation of functors to C++ file. * Style cleanups. * Rename CmdVelMuxNodelet -> CmdVelMux. * Add underscore to all variables in CmdVelSub class. * Move more implementation into the C++ file. * Add underscores to more variables. * More class variables with underscores. * Make priority and short_desc private class members. * Remove unused active_ member variable. * Remove the output_topic_name. This can mostly be accomplished by using standard remapping. Removing this loses the ability to remap it on the fly, but that's a pretty esoteric feature and would have to be supported on the downstream consumers as well. So I don't think it is a huge loss in functionality. * Enable additional compiler warnings, and fix the small problems pointed out. * Rename subs -> sub everywhere. It was really short for "subscriber", but it read like the plural of "sub". Resolve the ambiguity by just using "sub" * Remove the unused idx member variable. * Split common and individual timer callbacks. * Move allowed into the main class. * Make list_ public. In preparation for merging with CmdVelMux. * Remove getPriority(). In prepartion for making this a struct. * Remove << operator for CmdVelSub. And go ahead and make it a struct. * Smush all classes together. It really makes more sense this way. * Get rid of YAML-CPP < 0.5 code. * Remove more yaml-cpp < 0.5 fallback code. * Add in necessary includes. * Remove some unnecessary namespaces. * Port to ROS 2. * cmd_vel_mux Fix (kobuki-base#1) * Fixed duration of callbacks for the timeouts * Parameters as a map (kobuki-base#4) Switch to using a map for parameters. This makes the configuration file much nicer looking, though is a break for downstream consumers. * Add launch tests and linter checks. (kobuki-base#8) * Add launch tests and linter checks. * Small cleanups in the package.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@stonier How do you feel about making a release of this package into Foxy and Eloquent?
The text was updated successfully, but these errors were encountered: