Skip to content

Conversation

@ncruces
Copy link

@ncruces ncruces commented Jan 16, 2018

Fixes an issue where:

  1. dialog is shown;
  2. user presses "neutral" button;
  3. immediately call shouldShowRateDialog and get true.

This affects me because I'm not showing the dialog in onCreate (which is when settings are loaded). I call showRateDialogIfNeeded during the lifetime of my activity, and if the user presses "neutral" the dialog is show again and again until the activity is recreated and settings reloaded.

@ncruces ncruces closed this Jan 20, 2018
@ncruces
Copy link
Author

ncruces commented Jan 20, 2018

This is not enough to fix the issue. Reopened at #98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant