Added dismissRateDialog() function. #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• I've added dismissRateDialog() function. I've been need to change a very little piece of code to make this works.
kobakei
reviewed
Aug 7, 2017
Owner
kobakei
left a comment
kobakei
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I wrote some feedbacks.
| */ | ||
| public static void dismissRateDialog() { | ||
| if (dialog != null) | ||
| dialog.dismiss(); |
| // Weak ref to avoid leaking the context | ||
| private static WeakReference<AlertDialog> sDialogRef = null; | ||
|
|
||
| private static AlertDialog dialog; |
Owner
There was a problem hiding this comment.
Add @Nullable to dialog and builder
| @@ -1,20 +1,3 @@ | |||
| /* | |||
| * @param context | ||
| */ | ||
| public static void showRateDialog(final Context context) { | ||
| AlertDialog.Builder builder = new AlertDialog.Builder(context); |
Owner
There was a problem hiding this comment.
How about builder and dialog are not null? (= dialog is shown)
It may be better to do nothing on the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• I've added dismissRateDialog() function. I've been need to change a very little piece of code to make this works.