-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cobra flag helpers for better shell completion #541
Comments
This issue is stale because it has been open for 90 days with no |
I still want this. |
Hello @imjasonh , is this issue still available? |
Go for it! Let me know if you have any questions, I'd be happy to help. And thanks! |
Thank you |
Cobra has a helper methods which can make shell completion a little nicer:
MarkFlagFilename
tells Cobra that the flag represents a filename. This tells theko completion
logic to generate helpers to match filenames. (e.g.,ko apply -f <tab>
)MarkFlagRequired
tells Cobra that the flag is required, and prioritizes in completion if it's unset (e.g.,ko apply <tab>
prioritizes-f
over--preserve-import-paths
).Audit flags we configure and see if there are any that would benefit from being marked this way. Check that the expected behavior is actually observed when shell completion is configured.
The text was updated successfully, but these errors were encountered: