Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure() method should fail when the inputspec is not compatible, related with #70 #39

Open
gab1one opened this issue Feb 26, 2016 · 7 comments

Comments

@gab1one
Copy link
Member

gab1one commented Feb 26, 2016

If a generated node is configured, e.g. when connected to another node, the configuration must fail if the inputspec is not compatible.
This could be the case if no column of a required type is available.

@gab1one gab1one self-assigned this Feb 26, 2016
@gab1one gab1one changed the title Configure() method should fail when the inputspec is not compatible Configure() method should fail when the inputspec is not compatible, related with #70 May 9, 2016
@Squareys Squareys modified the milestone: knip-scijava-1.0.0-beta Sep 6, 2016
@Squareys
Copy link
Contributor

@dietzc Since in #49 we now require the Hook and have the column selection widget, which throws "NotConfigurableException" if no matching input column is available, this will be done with that, too, right?

@Squareys
Copy link
Contributor

@gab1one Ok if I remove the in progress label?

@dietzc
Copy link
Member

dietzc commented Sep 13, 2016

I think you are right @Squareys. Can you double-check and close the issue? However, the exception should be treated gracefully.

@Squareys
Copy link
Contributor

treated gracefully

The graceful part is usually already handled in KNIME (it should show the invalid settings dialog), but maybe we mean different things?
Do you mean still being able to save the settings (just display a warning), even though not actually valid?

@dietzc
Copy link
Member

dietzc commented Sep 14, 2016

We want default KNIME behaviour: Node is red, but can be configured (or so)?

@Squareys
Copy link
Contributor

We want default KNIME behaviour: Node is red, but can be configured (or so)?

Wouldn't default behaviour be not to allow configuring invalid settings? And if no auto-setting for the input column selection for example could be found (new node with no node connected at input set), then it is red?

@dietzc
Copy link
Member

dietzc commented Sep 22, 2016

Wouldn't default behaviour be not to allow configuring invalid settings? And if no auto-setting for the input column selection for example could be found (new node with no node connected at input set), then it is red?

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants