Skip to content

Commit 1f58031

Browse files
committed
Fix credo readability issues
1 parent ee0d725 commit 1f58031

File tree

10 files changed

+35
-11
lines changed

10 files changed

+35
-11
lines changed

time_tracker_backend/lib/time_tracker_backend.ex

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
defmodule TimeTrackerBackend do
2+
@moduledoc """
3+
This is primarily an example phoenix application for use showing off elm and
4+
phoenix integration.
5+
"""
6+
27
use Application
38

49
# See http://elixir-lang.org/docs/stable/elixir/Application.html
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
defmodule TimeTrackerBackend.GuardianSerializer do
2+
@moduledoc false
23
@behaviour Guardian.Serializer
34

45
alias TimeTrackerBackend.{Repo, User}
56

6-
def for_token(user = %User{}), do: { :ok, "User:#{user.id}" }
7-
def for_token(_), do: { :error, "Unknown resource type" }
7+
def for_token(user = %User{}), do: {:ok, "User:#{user.id}"}
8+
def for_token(_), do: {:error, "Unknown resource type"}
89

9-
def from_token("User:" <> id), do: { :ok, Repo.get(User, id) }
10-
def from_token(_), do: { :error, "Unknown resource type" }
10+
def from_token("User:" <> id), do: {:ok, Repo.get(User, id)}
11+
def from_token(_), do: {:error, "Unknown resource type"}
1112
end

time_tracker_backend/web/controllers/chart_controller.ex

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ defmodule TimeTrackerBackend.ChartController do
33

44
def index(conn, _params) do
55
conn
6-
|> render("index.json", data: static_data())
6+
|> render("index.json", data: static_data())
77
end
88

99
defp static_data() do
1010
[
11-
[ 1448928000000, 2 ],
12-
[ 1451606400000, 2 ],
13-
[ 1454284800000, 1 ],
14-
[ 1456790400000, 1 ]
11+
[1_448_928_000_000, 2],
12+
[1_451_606_400_000, 2],
13+
[1_454_284_800_000, 1],
14+
[1_456_790_400_000, 1]
1515
]
1616
end
1717
end

time_tracker_backend/web/models/organization.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
defmodule TimeTrackerBackend.Organization do
2+
@moduledoc """
3+
Organizations have many users and projects
4+
"""
5+
26
use TimeTrackerBackend.Web, :model
37

48
schema "organizations" do

time_tracker_backend/web/models/project.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
defmodule TimeTrackerBackend.Project do
2+
@moduledoc """
3+
Projects in our system
4+
"""
5+
26
use TimeTrackerBackend.Web, :model
37

48
schema "projects" do

time_tracker_backend/web/models/user.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
defmodule TimeTrackerBackend.User do
2+
@moduledoc """
3+
Users of our system.
4+
"""
5+
26
use TimeTrackerBackend.Web, :model
37

48
schema "users" do

time_tracker_backend/web/resolvers/user_resolver.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
defmodule TimeTrackerBackend.UserResolver do
2+
@moduledoc """
3+
Functions used to resolve user-related data for our GraphQL endpoint
4+
"""
5+
26
alias TimeTrackerBackend.{Repo, User}
37

48
def all(_args, _info) do

time_tracker_backend/web/schema.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
defmodule TimeTrackerBackend.Schema do
2+
@moduledoc "The schema for our GraphQL endpoint"
23
use Absinthe.Schema
34
import_types TimeTrackerBackend.Schema.Types
45

time_tracker_backend/web/schema/types.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
defmodule TimeTrackerBackend.Schema.Types do
2+
@moduledoc "The types used in our GraphQL endpoint"
23
use Absinthe.Schema.Notation
34

45
@desc "A user of our system"

time_tracker_backend/web/web.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ defmodule TimeTrackerBackend.Web do
3939

4040
alias TimeTrackerBackend.{User, Project, Organization}
4141

42-
defp order(query, "asc "<>field) do
42+
defp order(query, "asc " <> field) do
4343
field = String.to_existing_atom(field)
4444
from u in query,
4545
order_by: [asc: ^field]
4646
end
47-
defp order(query, "desc "<>field) do
47+
defp order(query, "desc " <> field) do
4848
field = String.to_existing_atom(field)
4949
from u in query,
5050
order_by: [desc: ^field]

0 commit comments

Comments
 (0)