Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling 'That's all at handstroke' #183

Open
centreboard opened this issue Apr 20, 2021 · 1 comment
Open

Calling 'That's all at handstroke' #183

centreboard opened this issue Apr 20, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@centreboard
Copy link
Collaborator

centreboard commented Apr 20, 2021 •
edited
Loading

'That's all at handstroke' becomes Change method in the RR audio

1) Update RR to use That's all audio
2) Edit the call to just emit That's all when processed by ComplibCompositionGenerator
@kneasle
Copy link
Owner

kneasle commented Apr 21, 2021 •
edited
Loading

I like option two more - this is a side effect of using an API designed for Handbell Stadium, and hopefully people will notice the super early That's All and stop at handstroke anyway. That reminds me actually, we should probably stop Wheatley from leaving the bells up at handstroke if --stop-at-rounds is set... Snap I had not seen your PR...

@centreboard centreboard added bug Something isn't working good first issue Good for newcomers labels Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@centreboard @kneasle