From a6c363f738d4eaed1bff77fd9f7cc2bd8757ac36 Mon Sep 17 00:00:00 2001 From: Reto Lehmann Date: Tue, 16 Jan 2024 07:59:53 +0100 Subject: [PATCH] Review improvements --- pkg/reconciler/revision/controller.go | 1 + test/e2e/encryption.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/reconciler/revision/controller.go b/pkg/reconciler/revision/controller.go index 4318cec05968..3a8db9f1919d 100644 --- a/pkg/reconciler/revision/controller.go +++ b/pkg/reconciler/revision/controller.go @@ -136,6 +136,7 @@ func newControllerWithOptions( } deploymentInformer.Informer().AddEventHandler(handleMatchingControllers) paInformer.Informer().AddEventHandler(handleMatchingControllers) + certificateInformer.Informer().AddEventHandler(handleMatchingControllers) // We don't watch for changes to Image because we don't incorporate any of its // properties into our own status and should work completely in the absence of diff --git a/test/e2e/encryption.go b/test/e2e/encryption.go index 18d2b06607d9..232646edda9d 100644 --- a/test/e2e/encryption.go +++ b/test/e2e/encryption.go @@ -73,7 +73,7 @@ func getCertificateClass(cm *corev1.ConfigMap) string { func getCertManagerCA(clients *test.Clients) (*corev1.Secret, error) { var secret *corev1.Secret - err := wait.PollImmediate(test.PollInterval, test.PollTimeout, func() (bool, error) { + err := wait.PollUntilContextTimeout(context.Background(), test.PollInterval, test.PollTimeout, true, func(context.Context) (bool, error) { caSecret, err := clients.KubeClient.CoreV1().Secrets(certManagerNamespace).Get(context.Background(), certManagerCASecret, metav1.GetOptions{}) if err != nil { return false, err