Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the shell wrapper #2843

Closed
wants to merge 1 commit into from
Closed

remove the shell wrapper #2843

wants to merge 1 commit into from

Conversation

Priyansurout
Copy link

@Priyansurout Priyansurout commented Sep 28, 2023 •
edited
Loading

Changes

broom : remove the shell wrapper from so the Knative projects could run the code-gen in go run ...

/kind

Fixes #2809

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Sep 28, 2023

@Priyansurout: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

broom : remove the shell wrapper from so the Knative projects could run the code-gen in go run ...

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Sep 28, 2023

Welcome @Priyansurout! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 28, 2023

Hi @Priyansurout. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Priyansurout
Once this PR has been reviewed and has the lgtm label, please assign kvmware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/assign @cardil

@cardil
Copy link
Contributor

cardil commented Oct 11, 2023 •
edited
Loading

Is this PR complete? I don't look like it, IMHO.

The goal of #2809 is to allow calling the code-gen without any shell middleman.

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@dprotaso
Copy link
Member

Going to close this PR as there hasn't been a reply from the author

@dprotaso dprotaso closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@cardil cardil

Labels
area/test-and-release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite the Knative code-gen to a Go-native tool
3 participants
@Priyansurout @dprotaso @cardil