Remove logging from pod watcher to avoid race conditions. (#1506)

markusthoemmes · web-flow · commit f1b82401dc8a · 2020-07-16T07:06:33.000-07:00
diff --git a/test/logstream/kubelogs.go b/test/logstream/kubelogs.go
@@ -113,16 +113,13 @@ func (k *kubelogs) watchPods(t test.TLegacy) {
 				watchedPods.Delete(p.Name)
 			case watch.Added, watch.Modified:
 				if watchedPods.Has(p.Name) {
-					t.Log("Already watching pod", p.Name)
 					continue
 				}
 				if podIsReady(p) {
-					t.Log("Watching logs for pod: ", p.Name)
 					watchedPods.Insert(p.Name)
 					k.startForPod(&eg, p)
 					continue
 				}
-				t.Log("Pod is not yet ready: ", p.Name)
 			}
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -113,16 +113,13 @@ func (k *kubelogs) watchPods(t test.TLegacy) {`
`113`	`113`	`watchedPods.Delete(p.Name)`
`114`	`114`	`case watch.Added, watch.Modified:`
`115`	`115`	`if watchedPods.Has(p.Name) {`
`116`		`- t.Log("Already watching pod", p.Name)`
`117`	`116`	`continue`
`118`	`117`	`}`
`119`	`118`	`if podIsReady(p) {`
`120`		`- t.Log("Watching logs for pod: ", p.Name)`
`121`	`119`	`watchedPods.Insert(p.Name)`
`122`	`120`	`k.startForPod(&eg, p)`
`123`	`121`	`continue`
`124`	`122`	`}`
`125`		`- t.Log("Pod is not yet ready: ", p.Name)`
`126`	`123`	`}`
`127`	`124`	`}`
`128`	`125`	`}()`