Services not using correct image for queue-proxy sidecar

[alanrichman]

Describe the bug

The configuration for overriding the image used by the queue-proxy sidecar is not working in my environment.

I am following the documentation to control the images used for Knative serving: https://knative.dev/docs/install/operator/configuring-serving-cr/#download-images-individually-without-secrets

Here is a sanitized version of my KnativeServing resource manifest

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  registry:
    imagePullSecrets:
    - name: my-secret
    override:
      3scale-kourier-gateway/kourier-gateway: registry.my-org.com/knative-serving-kourier-gateway:1.35.3
      activator: registry.my-org.com/knative-serving-activator:1.22.0
      autoscaler: registry.my-org.com/knative-serving-autoscaler:1.22.0
      autoscaler-hpa: registry.my-org.com/knative-serving-autoscaler-hpa:1.22.0
      controller: registry.my-org.com/knative-serving-controller:1.22.0
      net-kourier-controller/controller: registry.my-org.com/knative-serving-kourier-controller:1.22.0
      queue-proxy: registry.my-org.com/knative-serving-queue:1.22.0
      webhook: registry.my-org.com/knative-serving-webhook:1.22.0
  version: 1.22.0

The services continue to use the default image for the queue-proxy container. My cluster's config-deployment Config Map has the default image specified in it explicitly:

apiVersion: v1
kind: ConfigMap
metadata:
  name: config-deployment
  namespace: knative-serving
data:
  queue-sidecar-image: gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:371c23206b7bd924474b07e51435198579133eb98fba27a5cb3db9e6ba63b06b

Expected behavior

My expectation is that this would configure the Services to use my specified image for the queue-proxy container.

To Reproduce

1. Install Knative Operator v1.22.1
2. Create a KnativeServing resource with the queue-proxy image overridden
3. Observe Service deployments not using the specified image for the queue-proxy container

Knative release version

Knative Operator 1.22.1 with Knative Serving 1.22.0

[alanrichman]

Moved the issue over here from the Knative Serving repository since it is the Operator that introduces the KnativeServing CRD

[alanrichman]

I was able to identify a fix for this to make it behave in the way the documentation suggests that it should: #2314

[houshengbo]

Since the queue proxy image is configured within a configMap, you need to use the operator to override in the configMap to configure the all configMaps.

You should use the following section to configure the queue proxy image:

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  config:
    deployment:
      queue-sidecar-image: registry.my-org.com/knative-serving-queue:1.22.0

[alanrichman]

@houshengbo Thanks for pointing this out, that config change worked. Is there another deployment in Knative Serving that is supposed to use the Queue Proxy image as well? Can the example in the documentation I linked be updated to read as follows to reflect all image locations in the CRD?

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  registry:
    override:
      activator: docker.io/knative-images-repo1/activator:latest
      autoscaler: docker.io/knative-images-repo2/autoscaler:latest
      controller: docker.io/knative-images-repo3/controller:latest
      webhook: docker.io/knative-images-repo4/webhook:latest
      autoscaler-hpa: docker.io/knative-images-repo5/autoscaler-hpa:latest
      net-istio-controller/controller: docker.io/knative-images-repo6/prefix-net-istio-controller:latest
      net-istio-webhook/webhook: docker.io/knative-images-repo6/net-istio-webhook:latest
  config:
    deployment:
      queue-sidecar-image: docker.io/knative-images-repo7/queue-proxy-suffix:latest