Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on GKE spot instances #384

Open
2 tasks
cardil opened this issue Mar 18, 2024 · 5 comments
Open
2 tasks

Run tests on GKE spot instances #384

cardil opened this issue Mar 18, 2024 · 5 comments
Assignees
Labels
help wanted Extra attention is needed kind/enhancement

Comments

@cardil
Copy link
Contributor

cardil commented Mar 18, 2024

GKE provides, so-called spot instances. The main benefit, of using them, is a massive cost savings. The GKE with Spot instances doc describes how to use them.

Although, it would be a good idea to run tests on those nodes, some changes are probably needed in Knative:

  • ensure the tests could survive node termination
  • reconfigure test clusters to use more, but smaller nodes
@jasonsmithio
Copy link

/assign

@jasonsmithio
Copy link

A question with regards to this. What are the outcomes we are looking for in this test? I am happy to run it but want to know what would be considered a success wrt this issue.

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
@cardil
Copy link
Contributor Author

cardil commented Oct 10, 2024

/remove-lifecycle stale

@jasonsmithio Thanks, you wanna tackle this one. However, It is not a matter of writing some new tests for spot instances. The current Knative e2e tests have to work on a test cluster made of spot instances (the nodes of the cluster could be evicted at any time). We need to make sure that the tests do not produce false negatives due to random node evictions.

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2024
@jasonsmithio
Copy link

gotcha. It may take a while to test as we need the nodes to evict and do it enough times to collect enough data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement
Projects
Status: In Design/Discussion
Development

No branches or pull requests

2 participants