Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Format Go code #8349

Merged

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/eventing-writers
/assign knative/eventing-writers

Produced by: knative-extensions/knobots/actions/update-gofmt

Details:

 

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team November 26, 2024 13:11
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (65da6fc) to head (d6bb33e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8349   +/-   ##
=======================================
  Coverage   64.27%   64.27%           
=======================================
  Files         390      390           
  Lines       23279    23279           
=======================================
  Hits        14963    14963           
  Misses       7522     7522           
  Partials      794      794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
Copy link

knative-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@creydr
Copy link
Member

creydr commented Nov 26, 2024

/retest

1 similar comment
@creydr
Copy link
Member

creydr commented Nov 26, 2024

/retest

@pierDipi
Copy link
Member

/retest-required

@matzew
Copy link
Member

matzew commented Nov 27, 2024

/retest

1 similar comment
@matzew
Copy link
Member

matzew commented Nov 27, 2024

/retest

@knative-prow knative-prow bot merged commit aef3a14 into knative:main Nov 27, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants