Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobSink: Inject a KNATIVE_EXECUTION_MODE environment variable with value batch #8346

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Nov 25, 2024

To support long running functions in Knative Functions, we will inject a KNATIVE_EXECUTION_MODE environment variable with value batch so that function can change it's runtime behavior to read the event file rather than starting a long-running server.

Part of: knative/func#2586

Fixes #

Proposed Changes

  • inject a KNATIVE_EXECUTION_MODE environment variable with value batch to Jobs for JobSink

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

JobSink: Inject a `K_EXECUTION_MODE` environment variable with value `batch`

Renamed in #8350

Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2024
To support long running functions in Knative Functions, we will
inject a `KNATIVE_EXECUTION_MODE` environment variable with value
`batch` so that function can change it's runtime behavior to
read the event file rather than starting a long-running server.

Ref: knative/func#2586

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
Copy link

knative-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 01c8068 into knative:main Nov 26, 2024
32 of 35 checks passed
@pierDipi pierDipi deleted the jobsink-execution-mode branch November 26, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants