Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using twice hardcoded strings for the names of the Kube Secret keys, for AWS access/secret key vals #8345

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 25, 2024

Fixes #

Proposed Changes

  • as per title

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@knative-prow knative-prow bot requested review from aliok and creydr November 25, 2024 13:36
@matzew
Copy link
Member Author

matzew commented Nov 25, 2024

/assign @pierDipi

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.27%. Comparing base (65da6fc) to head (c695150).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...er/integration/source/resources/containersource.go 0.00% 6 Missing ⚠️
...iler/integration/sink/resources/container_image.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8345   +/-   ##
=======================================
  Coverage   64.27%   64.27%           
=======================================
  Files         390      390           
  Lines       23279    23279           
=======================================
  Hits        14963    14963           
  Misses       7522     7522           
  Partials      794      794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@matzew
Copy link
Member Author

matzew commented Nov 26, 2024

/retest

1 similar comment
@matzew
Copy link
Member Author

matzew commented Nov 27, 2024

/retest

…keys, for AWS access/secret key vals

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the use_constant_for_aws_secret_keys branch from 1a64cf2 to c695150 Compare November 27, 2024 08:40
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@matzew
Copy link
Member Author

matzew commented Nov 27, 2024

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
Copy link

knative-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/test unit-tests

@knative-prow knative-prow bot merged commit 91f1c79 into knative:main Nov 28, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants