-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using twice hardcoded strings for the names of the Kube Secret keys, for AWS access/secret key vals #8345
Avoid using twice hardcoded strings for the names of the Kube Secret keys, for AWS access/secret key vals #8345
Conversation
/assign @pierDipi |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8345 +/- ##
=======================================
Coverage 64.27% 64.27%
=======================================
Files 390 390
Lines 23279 23279
=======================================
Hits 14963 14963
Misses 7522 7522
Partials 794 794 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
1 similar comment
/retest |
…keys, for AWS access/secret key vals Signed-off-by: Matthias Wessendorf <[email protected]>
1a64cf2
to
c695150
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-tests |
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs