Fix unique name generator for auto-created EventType (#7160)

* fix: Fix unique name generator for auto-created EventType

* Fix nolint:gosec

* Remove leftover variable

Author: dsimansk

pkg/eventtype/eventtypes.go

@@ -18,7 +18,7 @@ package eventtype
 
 import (
 	"context"
-	"encoding/base64"
+	"crypto/md5" //nolint:gosec
 	"fmt"
 
 	"github.com/cloudevents/sdk-go/v2/event"
@@ -44,14 +44,14 @@ type EventTypeAutoHandler struct {
 	Logger          *zap.Logger
 }
 
-// generateEventTypeName is a pseudo unique name for EvenType object based on on the input params
+// generateEventTypeName is a pseudo unique name for EvenType object based on the input params
 func generateEventTypeName(name, namespace, eventType, eventSource string) string {
 	suffixParts := eventType + eventSource + namespace + name
-	suffix := base64.StdEncoding.EncodeToString([]byte(suffixParts))[:10]
-	return utils.ToDNS1123Subdomain(fmt.Sprintf("%s-%s-%s", "et", name, suffix))
+	suffix := md5.Sum([]byte(suffixParts)) //nolint:gosec
+	return utils.ToDNS1123Subdomain(fmt.Sprintf("%s-%s-%x", "et", name, suffix))
 }
 
-// AutoCreateEventType creates EventType object based on processed events's types from addressable KReference objects
+// AutoCreateEventType creates EventType object based on processed event's types from addressable KReference objects
 func (h *EventTypeAutoHandler) AutoCreateEventType(ctx context.Context, event *event.Event, addressable *duckv1.KReference, ownerUID types.UID) error {
 	// Feature flag gate
 	if !h.FeatureStore.IsEnabled(feature.EvenTypeAutoCreate) {

pkg/eventtype/eventtypes_test.go

@@ -129,21 +129,21 @@ func TestEventTypeAutoHandler_GenerateEventTypeName(t *testing.T) {
 			namespace:    "default",
 			eventType:    "events.type",
 			eventSource:  "events.source",
-			expectedName: "et-example-zxzlbnrzln",
+			expectedName: "et-example-eaed2996d719048dfae11b607d68b7ad",
 		},
 		{
 			name:         "EXAMPLE",
 			namespace:    "default",
 			eventType:    "events.type",
 			eventSource:  "events.source",
-			expectedName: "et-example-zxzlbnrzln",
+			expectedName: "et-example-f4d9f28cdbe397fe92eb5899e7294121",
 		},
 		{
-			name:         "emptyName",
+			name:         "",
 			namespace:    "default",
 			eventType:    "events.type",
 			eventSource:  "events.source",
-			expectedName: "et-emptyname-zxzlbnrzln",
+			expectedName: "et--72f2dad9d914dcd0445cae74ba99d15c",
 		},
 	}
 
@@ -158,6 +158,104 @@ func TestEventTypeAutoHandler_GenerateEventTypeName(t *testing.T) {
 	}
 }
 
+func TestEventTypeAutoHandler_GenerateEventTypeNameUnique(t *testing.T) {
+	type eventTypeMock struct {
+		name        string
+		namespace   string
+		eventType   string
+		eventSource string
+	}
+
+	testCases := []struct {
+		name           string
+		eventTypeA     eventTypeMock
+		eventTypeB     eventTypeMock
+		expectedUnique bool
+	}{
+		{
+			name: "Long equal name of addressable",
+			eventTypeA: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.A",
+			},
+			eventTypeB: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeB",
+				eventSource: "events.source.B",
+			},
+			expectedUnique: true,
+		},
+		{
+			name: "Long equal name & same source",
+			eventTypeA: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.A",
+			},
+			eventTypeB: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeB",
+				eventSource: "events.source.A",
+			},
+			expectedUnique: true,
+		},
+		{
+			name: "Long name with one char diff",
+			eventTypeA: eventTypeMock{
+				name:        "long-addressable-nameA",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.A",
+			},
+			eventTypeB: eventTypeMock{
+				name:        "long-addressable-nameB",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.B",
+			},
+			expectedUnique: true,
+		},
+		{
+			name: "All same input params are not unique",
+			eventTypeA: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.A",
+			},
+			eventTypeB: eventTypeMock{
+				name:        "long-addressable-name",
+				namespace:   "default",
+				eventType:   "com.example.organization.events.typeA",
+				eventSource: "events.source.A",
+			},
+			expectedUnique: false,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			resultA := generateEventTypeName(tc.eventTypeA.name, tc.eventTypeA.namespace, tc.eventTypeA.eventType, tc.eventTypeA.eventSource)
+			resultB := generateEventTypeName(tc.eventTypeB.name, tc.eventTypeB.namespace, tc.eventTypeB.eventType, tc.eventTypeB.eventSource)
+
+			if tc.expectedUnique {
+				if resultA == resultB {
+					t.Errorf("test case '%s', generated name '%s' x '%s' must be unique", tc.name, resultA, resultB)
+				}
+			} else {
+				if resultA != resultB {
+					t.Errorf("test case '%s', generated name '%s' x '%s' must be equal", tc.name, resultA, resultB)
+				}
+			}
+		})
+	}
+}
+
 func initFeatureStore(t *testing.T, enabled string) *feature.Store {
 	featureStore := feature.NewStore(logtesting.TestLogger(t))
 	cm := resources.ConfigMap(