Skip to content

Commit 84a331f

Browse files
[release-1.14] Fix possible nil pointer dereference in event-dispatcher (#7997)
* Fix possible nil pointer dereference in event-dispatcher * readErr -> err --------- Co-authored-by: Christoph Stäbler <[email protected]>
1 parent 3b3d77f commit 84a331f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/kncloudevents/event_dispatcher.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -325,11 +325,11 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
325325
dispatchInfo.ResponseHeader = response.Header
326326

327327
body := new(bytes.Buffer)
328-
_, readErr := body.ReadFrom(response.Body)
328+
_, err = body.ReadFrom(response.Body)
329329

330330
if isFailure(response.StatusCode) {
331331
// Read response body into dispatchInfo for failures
332-
if readErr != nil && readErr != io.EOF {
332+
if err != nil && err != io.EOF {
333333
dispatchInfo.ResponseBody = []byte(fmt.Sprintf("dispatch resulted in status \"%s\". Could not read response body: error: %s", response.Status, err.Error()))
334334
} else {
335335
dispatchInfo.ResponseBody = body.Bytes()
@@ -341,7 +341,7 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
341341
}
342342

343343
var responseMessageBody []byte
344-
if readErr != nil && readErr != io.EOF {
344+
if err != nil && err != io.EOF {
345345
responseMessageBody = []byte(fmt.Sprintf("Failed to read response body: %s", err.Error()))
346346
} else {
347347
responseMessageBody = body.Bytes()

0 commit comments

Comments
 (0)