Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Responsive Design Enhancements for Knative Docs Home Page #5994

Closed
wants to merge 9 commits into from
Closed

fix: Responsive Design Enhancements for Knative Docs Home Page #5994

wants to merge 9 commits into from

Conversation

asr2003
Copy link
Contributor

@asr2003 asr2003 commented May 26, 2024 •
edited
Loading

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asr2003
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2024
@asr2003 asr2003 marked this pull request as draft May 26, 2024 10:24
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2024
@netlify Netlify
Copy link

netlify bot commented May 26, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ffe288
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66535ac942c5530008b0c47c
😎 Deploy Preview https://deploy-preview-5994--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2024
@asr2003 asr2003 changed the title Test fix: Responsive Design Enhancements for knative.dev Home Page May 26, 2024
@asr2003 asr2003 marked this pull request as ready for review May 26, 2024 16:14
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2024
@knative-prow knative-prow bot requested review from nainaz and ReToCode May 26, 2024 16:14
@asr2003
Copy link
Contributor Author

asr2003 commented May 26, 2024 •
edited
Loading

@Cali0707 @zainabhusain227 I am almost done with changes outlined in the issue. PTAL

https://deploy-preview-5994--knative.netlify.app/

@asr2003
Copy link
Contributor Author

asr2003 commented May 26, 2024

/review

@aliok
Copy link
Member

aliok commented May 27, 2024

hey @asr2003

This issue is part of an LFX project for this summer. If you're interested in the program, please focus on your proposal, instead of working on the project.

Thanks

@asr2003
Copy link
Contributor Author

asr2003 commented May 27, 2024

@aliok Thanks for the clarification. I had worked on it as part of contributing to the repo so that I can get familiar with the codebase and it will make to craft a good proposal. I think got misconception that this issue isn't linked in upstream issue.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
@asr2003
Copy link
Contributor Author

asr2003 commented May 28, 2024

/upstream

@asr2003 asr2003 changed the title fix: Responsive Design Enhancements for knative.dev Home Page fix: Responsive Design Enhancements for Knative Docs Home Page May 28, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2024
@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

@nainaz nainaz Awaiting requested review from nainaz

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Responsive Design Enhancements for knative.dev Home Page
3 participants
@asr2003 @aliok @knative-prow-robot