Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set custom fields on generate HTTPProxy specs #347

Closed
johanbrandhorst opened this issue Oct 31, 2020 · 9 comments
Closed

Ability to set custom fields on generate HTTPProxy specs #347

johanbrandhorst opened this issue Oct 31, 2020 · 9 comments

Comments

@johanbrandhorst
Copy link

Hi, great work on the project. I'm been playing around with it in my local cluster and I'm wondering if there is any way that I can configure the generated HTTPProxies? For example, to set an ExtensionService or to configure CORS settings for the proxy. Could this be exposed via the config-contour somehow?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2021
@johanbrandhorst
Copy link
Author

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2021
@johanbrandhorst
Copy link
Author

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2021
@dprotaso
Copy link
Contributor

Hey sorry missed this - I think what would be the best scenario is if net-contour could be good citizen with a cooperating webhook that can set these additional properties on create/update. I think now the controller would reconcile any changes away.

This sorta becomes a larger issue cause we'd want something like this in our controller framework so it would work across the board.

@dprotaso
Copy link
Contributor

I'd like to attempt the above prior to doing a solution that's custom to net-contour

@johanbrandhorst
Copy link
Author

Sounds good, is there a tracking issue for such an effort?

@dprotaso
Copy link
Contributor

Made the tracking issue issue for this as a general problem.

If you have specific things you're looking to configure it may make sense to create separate issues.

ie. HTTP Auth - #491

@johanbrandhorst
Copy link
Author

OK, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants