-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github action arm image built #948
base: main
Are you sure you want to change the base?
Conversation
…t is x86-64 arch Signed-off-by: Zhonghu Xu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…t is x86-64 arch Signed-off-by: Zhonghu Xu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -0,0 +1,26 @@ | |||
FROM ghcr.io/kmesh-net/kmesh-build:latest AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need a new dockerfile?Why not modify the original dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
/lgtm |
What type of PR is this?
What this PR does / why we need it:
: without this, though the docker image is ar,64 arch but the kmesh-daemon within it is just x86-64.
Which issue(s) this PR fixes:
Fixes #944
Special notes for your reviewer:
Does this PR introduce a user-facing change?: