Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CNI installer #730

Open
hzxuzhonghu opened this issue Aug 14, 2024 · 1 comment
Open

Improve CNI installer #730

hzxuzhonghu opened this issue Aug 14, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@hzxuzhonghu
Copy link
Member

What would you like to be added:

Currently cni installer is within the kmesh daemon, however when the daemon panic unexpected, the cni does not have a chance to uninstall all the cni configs.

If the kubeconfig kmesh-cni using is not out of date, then after kmesh-daemon updated, it can start up successfully.
However if the kubeconfig's token is out dated, the the above procedure would fail.

Several solutions come up to my mind:

  1. Do clean up the cni config at the end of https://github.com/kmesh-net/kmesh/blob/main/build/docker/start_kmesh.sh#L54
  2. Add a go routine in cni installer, watch the token file, update the kubeconfig when token modified. This would make sure the kubeconfig can not expire easily.
  3. Make kmesh-cni CmdAdd never fail, even it failed, we return success. And depend on manage controller to manage workload eventually.

Why is this needed:

@hzxuzhonghu hzxuzhonghu added the kind/enhancement New feature or request label Aug 14, 2024
@hzxuzhonghu
Copy link
Member Author

cc @YaoZengzeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant