Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross namespace waypoint capture #697

Open
hzxuzhonghu opened this issue Aug 7, 2024 · 2 comments
Open

Allow cross namespace waypoint capture #697

hzxuzhonghu opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@hzxuzhonghu
Copy link
Member

What would you like to be added:

Currently we have supported namespace/service waypoint capture since kmesh v0.4, plus istio 1.22+

As istio upstream has supported, cross namespace waypoint in the upcoming 1.23 release, we need to figure out what do we miss in the kmesh to support it.

Why is this needed:

@hzxuzhonghu hzxuzhonghu added the kind/enhancement New feature or request label Aug 7, 2024
@hzxuzhonghu
Copy link
Member Author

As to how to use that feature, it requires user to set

	// AmbientUseWaypointLabelLabel is the label used to specify which waypoint should be used for a given pod, service, etc...
	AmbientUseWaypointLabel = "istio.io/use-waypoint"

alongside with

/ AmbientUseWaypointNamespaceLabel is a label used to indicate the namespace of the waypoint (referred to by AmbientUseWaypointLabel).
	// This allows cross-namespace waypoint references. If unset, the same namespace is assumed.
	AmbientUseWaypointNamespaceLabel = "istio.io/use-waypoint-namespace"

Besides that, no other api is changed. So in kmesh, we may not need to to do much work on this.

But some test coverage and document is needed

@YaoZengzeng
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants