You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@hzxuzhonghu Seems like in case of tcp_probe we are converting to host byte and in case of sockops we are converting to network byte order. So which order is preferred for unifying the port byte order?
What would you like to be added:
In tcp probe, we construct sock tuple with https://github.com/kmesh-net/kmesh/blob/main/bpf/kmesh/probes/tcp_probe.h#L118
But in sokops, we use https://github.com/kmesh-net/kmesh/blob/main/bpf/kmesh/workload/sockops.c#L132
They are much similar except the port byte order, this lead to two different ways of parsing the tuple in usersapce go implemention.
Why is this needed:
To reduce developers burden on understanding the byte order.
The text was updated successfully, but these errors were encountered: