Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LayernormGRU #2

Closed
ulf1 opened this issue Jan 15, 2020 · 3 comments
Closed

Implement LayernormGRU #2

ulf1 opened this issue Jan 15, 2020 · 3 comments

Comments

@ulf1
Copy link
Member

ulf1 commented Jan 15, 2020

No description provided.

@thegodone
Copy link

any update on this Issue ?

@ulf1
Copy link
Member Author

ulf1 commented May 23, 2022

@thegodone Sorry for the late reply. This repo went into the tensorflow/addons repo https://github.com/tensorflow/addons/blob/d126b4690e7858b85fdb3c9e9a61143c31e9fddb/tensorflow_addons/rnn/layer_norm_simple_rnn_cell.py (PR: tensorflow/addons#841)

Right now TFA (tensorflow addons) has RNNs and LSTMs with layernorm. It's probably easier to adjust the LSTMCell code for GRU, e.g., https://github.com/tensorflow/addons/blob/d126b4690e7858b85fdb3c9e9a61143c31e9fddb/tensorflow_addons/rnn/layer_norm_lstm_cell.py

I will post an issue in TFA and link you there.

@ulf1 ulf1 closed this as completed May 23, 2022
@ulf1 ulf1 mentioned this issue May 23, 2022
Closed
@ulf1
Copy link
Member Author

ulf1 commented May 23, 2022

@thegodone see tensorflow/addons#2710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thegodone @ulf1