Issue22 : restructured the image-processing module. #30
Conversation
here I have documented the methods in image_visualize.py asper what I could understand. Please go through it .I tried to create a function for implementing all these methods but I don't know which dataset to implement it on. A little more clarification from your end will be appreciated. Thank you
have updated the changes by running on local machine.please have a look also trying to change the .rst file you suggested me for
* Added the standardisation function * Added Mean Normalization & changed name of the function standardize to z_score_normalization * Added the standardisation function * Added Mean Normalization & changed name of the function standardize to z_score_normalization Co-authored-by: ask149 <[email protected]>
|
Hi @Shankhanil, Could you please resolve the conflicting files by rebasing your branch with the upstream master? @harshasridhar Can you please review the Pull request changes? |
|
@Shankhanil we can review it either tomorrow or day after tomorrow,let me know when you've fixed the merge conflicts |
| @@ -72,8 +72,13 @@ def fill_numerical_na(self, ret = False): | |||
| self.df[col] = y | |||
| except Exception as e: | |||
| pass | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
The conflict seems not resolved yet
| @@ -84,6 +89,25 @@ def normalize_numerical(self): | |||
| for col in self.numerical_column_list: | |||
| if col != self.target_column: | |||
| self.df[col]=(self.df[col]-self.df[col].min())/(self.df[col].max()-self.df[col].min()) | |||
| def standardize(self): | |||
There was a problem hiding this comment.
Remove this file from the PR to avoid any conflicts.
| def __init__(self, data, labels, boxes=None): | ||
| """Constructor for Image Data Visualization. |
There was a problem hiding this comment.
Remove this file as well from the PR, to avoid conflicts. Can you please confirm if you have successfully rebased and taken the latest pull?
There was a problem hiding this comment.
I had taken the latest pull, but maybe I had made some minor changes while testing the code, which might've caused the conflicts. Resolving them nw.
There was a problem hiding this comment.
Can you please guide me on how to remove this file from PR
There was a problem hiding this comment.
Try using following commands
git checkout HEAD^ -- /path/to/file
git commit -m 'Message'
git push
There was a problem hiding this comment.
I tried this, it's showing the message
nothing to commit, working tree clean
Am i missing smth?
There was a problem hiding this comment.
Let us move the conversation to slack
There was a problem hiding this comment.
Slack channel pls?
|
Will update them ASAP. |
|
Let is know once you are done resolving the conflict and updating the changes. |
|
Please review the PR |
No description provided.