Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Preview Sketch Does Not Update on Reset #19

Open
kkevn opened this issue Jan 21, 2021 · 1 comment
Open

3D Preview Sketch Does Not Update on Reset #19

kkevn opened this issue Jan 21, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kkevn
Copy link
Owner

kkevn commented Jan 21, 2021

Summary:
Pressing the Reset button in the toolbar's options menu should immediately clear the 3D preview sketch back to its default state with no effects displaying.

Steps to reproduce:

  1. Navigate to the profile creation page with the 3D preview sketch
  2. Apply any combination of at least one effect
  3. Tap the Reset option in the toolbar's options menu
  4. Observe the 3D preview sketch

Actual result:
The 3D preview sketch "saves" the last frame it rendered before being reset, causing it to display part of the just recently cleared effects.

Expected result:
The 3D preview sketch should display no effects whatsoever, essentially returning it to its default state.

@kkevn kkevn added the bug Something isn't working label Jan 21, 2021
@kkevn
Copy link
Owner Author

kkevn commented Mar 15, 2021

This issue has been fixed for when the sketch has no effects in the list to render. However, a similar issue occurs when multiple effects were present and then one changed in some way, such as reordering or removing a single effect.

May require rewrite of how the sketch is rendering effects; bug possibly due to the current method of scanline rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant