Provide a self-contained plugin file

[drzraf]

This great plugin would be more used if it could fit in a self-contained perl-script rather than a whole make/installation.
Hint: The make could make concatenation of the perl-code of the libraries?

[szepeviktor]

Or it could be a proper Debian package.

[roidelapluie]

I'd rather have proper packages

[meersjo]

I agree, proper packages would be superior, especially since they also can take into account the differing directory structures on various distributions.

Also, it's been a long time since I did some proper perl, but I suspect that perl modules depend on being stored in separate files?

[szepeviktor]

The first step could be a module on CPAN
https://perldoc.perl.org/perlnewmod.html

[meersjo]

I don't believe that is appropriate - CPAN modules are intended for generic functionality; this is a specific software that is only useful in it's own context - monitoring a MySQL installation. Now, if you were to generalize this into perl::mMnin::monitorThing that would be OK, but given that we already import perl::Munin, which is basically that, I don't think that would be particularly worthwile.

…

From: "Viktor Szépe" ***@***.***> To: "kjellm/munin-mysql" ***@***.***> Cc: "meersjo" ***@***.***>, "Comment" ***@***.***> Sent: Friday, 7 April, 2017 13:00:48 Subject: Re: [kjellm/munin-mysql] Provide a self-contained plugin file (#92) The first step could be a module on CPAN https://perldoc.perl.org/perlnewmod.html — You are receiving this because you commented. Reply to this email directly, view it on GitHub , or mute the thread .

-- Unhappiness is discouraged and will be corrected with kitten pictures.

[szepeviktor]

OK.
Executable files could be packaged also.
example: https://anonscm.debian.org/cgit/pkg-perl/packages/libdbi-perl.git/tree/Makefile.PL#n91
another one: https://metacpan.org/source/TIMB/DBI-1.636/Makefile.PL#L91
docs: https://perldoc.perl.org/ExtUtils/MakeMaker.html#Using-Attributes-and-Parameters See EXE_FILES

Actually I don't speak PERL.

[szepeviktor]

I think packaging is mainly for maintenance (no stray files) and updates.

Installation could be cpan Munin::MySQL::Graph or apt-get install munin-plugin-mysql created by cpan2deb in dh-make-perl

[kjellm]

I don't think you can get cpan to install stuff to /etc/munin. We need to put mysql.conf under /etc/munin/plugin-conf.d/. And mysql under /etc/munin/plugins. So we would need an extra install step even if we make a CPAN module.

[szepeviktor]

So we would need an extra install step even if we make a CPAN module.

Currently mysql.conf needs manual configuration.

When configuring mysql.conf one may create a symlink for mysql in /etc/munin/plugins (as in Debian)

[szepeviktor]

Example instructions

Installation

1. Please install the perl module: cpan Munin::MySQL::Graph
2. Enter your DB credentials in /etc/munin/plugin-conf.d/mysql.conf. Skeleton configuration file can be found in ...
3. Activate the plugin by creating a symlink: ln -s .../mysql /etc/munin/plugins/
4. Restart munin-node