Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global appState object to track article and asset loading, and provide spinner messaging accordingly #1126

Open
Jaifroid opened this issue Sep 15, 2023 · 3 comments · May be fixed by #1310
Open

Use global appState object to track article and asset loading, and provide spinner messaging accordingly #1126

Jaifroid opened this issue Sep 15, 2023 · 3 comments · May be fixed by #1310
Labels
backend user interface
Milestone
v4.3

Comments

@Jaifroid
Copy link
Member

Following on from #1123, a "universal" messaging solution could be provided without altering the DOM in the messaging channel by leveraging the global appState object. At various points in the back end, this object can be updated to show the loading state. If using libzim (#870), then the state would be updated in the interface between app.js and the libzim worker, but messaging would be more limited as we don't have an API to report on the internal libzim decoding state.
@Jaifroid Jaifroid added this to the v4.1 milestone Sep 15, 2023
@Jaifroid Jaifroid mentioned this issue Sep 15, 2023
Merged
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
@asmit27rai
Copy link

@Jaifroid Please Assign This Issue To Me.

@Jaifroid
Copy link
Member Author

@asmit27rai This isn't a good first issue. There are lots of complexities to it, and it involves a change of architecture for the app. So I strongly suggest you select another issue.

@THEBOSS0369 THEBOSS0369 linked a pull request Feb 17, 2025 that will close this issue
Open
@THEBOSS0369
Copy link
Collaborator

THEBOSS0369 commented Feb 17, 2025 •
edited
Loading

Hey @Jaifroid Sir i have created a pr for this issue please take a look when you have some time. Link #1310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend user interface
Projects
None yet
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Added global appstate object to track article and asset Loading THEBOSS0369/kiwix-js
3 participants
@Jaifroid @THEBOSS0369 @asmit27rai