-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Apple Pay and use the “Donate with Apple Pay” button for "Support Kiwix" #753
Comments
Only Appke store pay should work with Applepay, other build (dmg) should have the traditional link. |
I have applied with Benevity/Apple Pay to get us approved. They should respond in a few days. |
@Popolechien any news on this? Should we move that to 3.5.0? |
@Popolechien We need an update here before implementing the feature. |
From Apple:
|
@BPerlakiH You need anything else to move forward with the code? |
Thank you @kelson42, I think initially it should be good, if anything arise while implementing it, I will let you know. |
I've found the following things we need:
My question is do we have a payment provider? My understanding is that once we have payment provider they will give us a CSR file we can use to create our Apple Payment Certificate here: |
@BPerlakiH Yes, we have Stripe and we should use it. Can you handle the details directly with @Popolechien please? |
@kelson42 I managed to put together the initial code part of this, with a very basic payment sheet, that Apple provides. |
ipad_payment.mov |
Ok so I looked on Stripe to generate a CSR certificate and that clearly is above my skillset. @rgaudin can you please look into it? |
@BPerlakiH I've created the CSR on Stripe and requested the certificate from Apple using it and received the certificate which I uploaded to Stripe as well. Both seem happy. Do you need anything else? |
Thank you very much. |
A: not really, but potential donors should be given the choice of making this a one-time or monthly recurring donation (annual is never used, and donations will likely be flagged as coming from iOS so the priority and comment parts can also be ignored). I don't know how much leeway you have (or how much space is available before the screen gets crowded), but 10/34/custom amount is a decent range of choices. Let me know what is doable within a reasonable amount of work (e.g. if it is a full day to implement a distinct recurring donation panel, then never mind and just make it a radio button for people to chose). |
Thank you, I am looking into it what's the best way to achieve it. |
@BPerlakiH Do you have gain clarity here about the path to follow? |
@kelson42 Yes, we need the user input in terms of what amount he/she wants to donate. https://github.com/user-attachments/assets/70284c82-e23d-4d22-aef1-d6dff1291081 |
Thanks a lot @BPerlakiH. Two questions:
|
Great ; I think the feature is here and we should work on making it a bit more appealing. A sentence (from @Popolechien, telling users why we ask for donations, etc), an icon maybe (love-receiving Kiwix?) and probably an Apple Pay logo as we want users to know that they wont need to take out their credit card to make a donation. |
I'd recommend sticking to the Signal playbook and have a minimalist text. Here is what they have (the Read more link adds a little popup with a bit more text but nothing much else except for a bigger heart - I do not think we need to go that route. So for the header text here is my suggestion
Note: as in the Signal banner the first line "No ads, no tracking" should be in a bigger font. |
Latest Signal is a bit different. First of all, the donate menu is inside the Settings. Screen.Recording.2024-10-04.at.10.mp4I'm with you on following what others with more resources and success have (probably) thought-through and done but that should not prevent us from making our own decisions |
Thank you for the feedback.
We can add as many currencies as we want (eg. Signal is using all possible currencies of the world), the limitation will come not from the development process, but rather from the payment provider, they might not accept all of them. On the plus side this is convenient for the user, on the other hand the whole section of donations will become dependent on "being online", and not just the final "Apple Pay" button. @rgaudin Thanks for the suggestion with Signal, I did checked their iOS app as well, and that looks good. In terms of making it look nice, I think the iOS part is where the nice look and feel will end. On macOS the system provided components aren't that nice, to be honest... There's no real comparison, as there's no donation section for Signal macOS app, but Apple Pay will work equally good on macOS. |
Additionally from what I can see on Signal, is that there's also a minimum amount for one time donation defined as well (USD 3$). |
@BPerlakiH I think the $3 minimum is to discourage fraudulent transactions IIRC so we might as well implement it unless it's bein implemented by default. As for currency let's default to EUR/USD only based on user location, with USD being the "real" default (that is, for non-EU users) and no bothering with FOREX adjustments. |
We should go now for a minimal version, with only USD and no custom design. It has to be clean and working bit nothing more. Improvements and refinements ideas should be tracked in new issues. It's important now to quickly move on the PR. Remark: It's important his feature to have no impact on custom apps |
Following Apple's recommendations for non-profit organisations:
https://developer.apple.com/apple-pay/nonprofits/
We should implement Apple Pay and use the "Donate with Apple Pay" button.
This should be done smartly so it works fine for custom apps as well
The text was updated successfully, but these errors were encountered: