Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet links not working #242

Closed
rgaudin opened this issue Apr 20, 2023 · 2 comments
Closed

Magnet links not working #242

rgaudin opened this issue Apr 20, 2023 · 2 comments
Assignees

Comments

@rgaudin
Copy link
Member

rgaudin commented Apr 20, 2023

Mirrorbrain generated magnets are incorrect.

According to the spec, here are the issues:

  • encoding:
    • & strings should be &
    • as= should be urlencoded
    • tr= should be urlencoded
  • Webseed should be declared with ws=. as= is a fallback, not a webseed.
  • Ideally we should have one ws= for each mirror.
  • Missing xs=. This should be a link to the torrent file. Without it the webseed is useless as the magnet doesn't contain the torrent metadata and would thus wait forever to retrieve the metadata from a peer which has it (might happen if another BT user is seeding using a .torrent file… but unlikely). Create a super-seeder docker image/container #43 would help of course.

This is upstream ; probably invalidated by #239

@kelson42
Copy link
Contributor

Which part of this ticket has not been fixed/workarounded with kiwix/libkiwix#1001?

@rgaudin
Copy link
Member Author

rgaudin commented Oct 14, 2023

None

@rgaudin rgaudin closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants