From 9cf141ee5bfb0dec9bacf943af71a3c0f7f09520 Mon Sep 17 00:00:00 2001 From: Jan Skrasek Date: Tue, 28 Mar 2023 18:32:53 +0200 Subject: [PATCH] build check LFS files --- .github/workflows/build.yml | 4 ++++ contributing.md | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ea2d1c2c9..806af3405 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -14,6 +14,10 @@ jobs: - uses: actions/checkout@v3 with: lfs: 'true' + + - name: Check LFS file (install git lfs and commit screenshots again if failing) + run: git lfs fsck --pointers + - name: set up JDK 18 uses: actions/setup-java@v3 with: diff --git a/contributing.md b/contributing.md index c52bd1ff3..7b459349b 100644 --- a/contributing.md +++ b/contributing.md @@ -23,7 +23,7 @@ Our code review will focus on: - discuss the API of the composable first; - add the component - composables with KDoc; -- add screenshots tests covering basic rendering of the component; Locally recorded screenshots may produce changes to all PNG files, push only the relevant ones. +- add screenshots tests covering basic rendering of the component; Locally recorded screenshots may produce changes to all PNG files, push only the relevant ones. Don't forget to install Git LFS, if installed properly, screenshots are automatically committed as LFS files. - add catalog demonstration; - add entry into `component-status.yaml`; - add documentation to docs (component.mdx) including UI testing documentation; resolve the correct name using [the Orbit repo](https://github.com/kiwicom/orbit/tree/master/docs/src/documentation) and naming pattern using the dir name as a file name;