Skip to content

Commit

Permalink
build check LFS files
Browse files Browse the repository at this point in the history
  • Loading branch information
hrach committed Mar 28, 2023
1 parent d308d4e commit 9cf141e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: 'true'

- name: Check LFS file (install git lfs and commit screenshots again if failing)
run: git lfs fsck --pointers

- name: set up JDK 18
uses: actions/setup-java@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Our code review will focus on:

- discuss the API of the composable first;
- add the component - composables with KDoc;
- add screenshots tests covering basic rendering of the component; Locally recorded screenshots may produce changes to all PNG files, push only the relevant ones.
- add screenshots tests covering basic rendering of the component; Locally recorded screenshots may produce changes to all PNG files, push only the relevant ones. Don't forget to install Git LFS, if installed properly, screenshots are automatically committed as LFS files.
- add catalog demonstration;
- add entry into `component-status.yaml`;
- add documentation to docs (component.mdx) including UI testing documentation; resolve the correct name using [the Orbit repo](https://github.com/kiwicom/orbit/tree/master/docs/src/documentation) and naming pattern using the dir name as a file name;
Expand Down

0 comments on commit 9cf141e

Please sign in to comment.