Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option in kitspace.yaml for checking a specific SHA #568

Open
AbdulrhmnGhanem opened this issue Apr 4, 2023 Discussed in #535 · 2 comments
Open

An option in kitspace.yaml for checking a specific SHA #568

AbdulrhmnGhanem opened this issue Apr 4, 2023 Discussed in #535 · 2 comments
Labels
processor Relating to the asset processor

Comments

@AbdulrhmnGhanem
Copy link
Member

Discussed in #535

Originally posted by AbdulrhmnGhanem December 30, 2022
In #526 (comment), I proposed using forked repos for registry borads. But after thinking about it I think there is a better solution.

The forked repos approach is problematic because we have to be alerted whenever a user makes a breaking change in the repo, then we have to fork this repo and maintain it which won't scale well when the numbers of repos increases.

Instead, we can introduce an option to in kitspace.yaml to pin the project a specific SHA if this option isn't used we will use the HEAD of the repo as usual. We can open PRs in the repos in the registry to add this option so we won't need to maintain a registry file for current and future repos.

@AbdulrhmnGhanem AbdulrhmnGhanem added the processor Relating to the asset processor label Apr 4, 2023
@AbdulrhmnGhanem AbdulrhmnGhanem added this to the alpha-2 milestone Apr 4, 2023
@kasbah
Copy link
Member

kasbah commented May 23, 2023

We were thinking about something like this in the yaml.

releases:
  - name: v1
    ref: v1.0.0

or

releases:
  - name: develop
    ref: develop

But it still gets confusing as to what kitspace.yaml will be used when you do this.

For now let's just reset origin/HEAD to whatever is in the registry.json.

@AbdulrhmnGhanem
Copy link
Member Author

Moving this out of alpha-2, registry projects are handled via #592

@AbdulrhmnGhanem AbdulrhmnGhanem removed this from the alpha-2 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor Relating to the asset processor
Projects
None yet
Development

No branches or pull requests

2 participants