Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to no login/whitelist #74

Open
abe33 opened this issue Jan 15, 2019 · 0 comments
Open

Migration to no login/whitelist #74

abe33 opened this issue Jan 15, 2019 · 0 comments

Comments

@abe33
Copy link
Contributor

abe33 commented Jan 15, 2019

This is an issue just to keep track of the things in the installer that will be affected by the login and whitelist removal.

A quick reminder first, unlike Atom, VSCode install flow setup and views are largely done in the plugin itself.

  • Do we want to keep all the account steps in the first place? I feel this could be removed entirely to let the copilot handle that and make the install flow just a download and install task.
  • If not, is the authenticate step still relevant? I think here, the now removed authenticateSessionID should be brought back in the step object if we want to keep that step. That function was only used here so it's more relevant to have it in the step rather than exposed by the API.
  • Whitelist steps are only a thing in VScode, it still runs an old version of the kite-installer before we removed these steps.
  • The whole vscode install flow should be reworked. But this should be done only after merging Switch to webview api vscode-plugin#174 (switch to webview API)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant