Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider version tagging repo #87

Open
lread opened this issue Jan 7, 2023 · 5 comments
Open

Consider version tagging repo #87

lread opened this issue Jan 7, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lread
Copy link

lread commented Jan 7, 2023

Hiya! I noticed that kit is using rewrite-clj.

Rewrite-clj runs the tests of libraries that use it against rewrite-clj main branch.
This helps me to discover when a change I make to rewrite-clj might break some existing lib that uses it.
To stay sane, I only run against the latest released version of libs.

If you were to start version tagging the kit GitHub repo when releasing kit, I could add it to the rewrite-clj suite. I think kit-generator is the lib of interest for rewrite-clj, ya?

If this is not interesting to you, that's totally fine too. Lemme know.

@yogthos
Copy link
Collaborator

yogthos commented Jan 7, 2023

Hi, I think that'd be a good idea. We could set up bb script to tag as part of the deploy.

@nikolap
Copy link
Member

nikolap commented Jan 8, 2023

Agreed, that sounds helpful for many reasons. Since we have multiple versions and deploys in a single repo, we could do something such as the tauri project does and tag the version with the package name + version, e.g. kit-generator 0.1.7.

@nikolap nikolap added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2023
@lread
Copy link
Author

lread commented Jan 8, 2023

Cool! Related, but could be treated as a separate issue, is including scm info in the poms of released jars. This allows tools like clojars and cljdoc to point back the sources (and articles) for a release.

@yogthos
Copy link
Collaborator

yogthos commented Jan 9, 2023

That's a good call as well, and I think makes sense to keep it all part of the same issue.

@markokocic
Copy link
Member

Agreed, that sounds helpful for many reasons. Since we have multiple versions and deploys in a single repo, we could do something such as the tauri project does and tag the version with the package name + version, e.g. kit-generator 0.1.7.

Do we actually have a use case where we need to have different version for kit libraries? I don't see a use case where someone will update one library but not the other. Since they are all used together in a kit project, it may as well make sense for all of them to have the same version and the same tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants