Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitsound got parsed incorrectly #21

Open
minetoblend opened this issue Jan 18, 2024 · 1 comment
Open

Hitsound got parsed incorrectly #21

minetoblend opened this issue Jan 18, 2024 · 1 comment

Comments

@minetoblend
Copy link

I've noticed that in some rare cases the sampleset is off on some hitobjects after parsing the .osu file.
I've applied the standard ruleset to the beatmap, if that makes any difference.

Beatmap to reproduce:
https://osu.ppy.sh/beatmapsets/2109375#osu/4427449

00:37:399 (5) - Sampleset in hitObject.nodeSamples should be Soft but it's Normal for some reason

@kionell
Copy link
Owner

kionell commented Jan 19, 2024

Actually, I'm aware of that problem. It's happening because beatmap decoder lacks some sample control point logic right after beatmap parsing. I was working on that stuff before, so I just need to finish an update for osu-classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants