Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dxl_basic_functions #21

Open
csherstan opened this issue Aug 29, 2018 · 0 comments
Open

Refactor dxl_basic_functions #21

csherstan opened this issue Aug 29, 2018 · 0 comments

Comments

@csherstan
Copy link
Collaborator

dxl_basic_functions.py is written in such a way the you have to go in and tweak the code by hand to set the port, motor id, etc.
I suggest it should be refactored into a class to which you can pass in the communications information.
Also, I noticed that there were a number of calls in there that were specific to the MX64, like accessing the registers. This could easily be refactored so that the appropriate motor is passed into the class when it is instantiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant