refactor(Unittest): simplifiy boolean assignment in Helpers::has_internet method

kilofox · kilofox · commit 1bf00d3bbf41 · 2025-03-13T18:51:49.000+08:00
diff --git a/modules/unittest/classes/Kohana/Unittest/Helpers.php b/modules/unittest/classes/Kohana/Unittest/Helpers.php
@@ -24,7 +24,7 @@ public static function has_internet()
             // The @ operator is used here to avoid DNS errors when there is no connection.
             $sock = @fsockopen("www.google.com", 80, $errno, $errstr, 1);
 
-            self::$_has_internet = (bool) $sock ? true : false;
+            self::$_has_internet = (bool) $sock;
         }
 
         return self::$_has_internet;

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public static function has_internet()`
`24`	`24`	`// The @ operator is used here to avoid DNS errors when there is no connection.`
`25`	`25`	`$sock = @fsockopen("www.google.com", 80, $errno, $errstr, 1);`
`26`	`26`
`27`		`- self::$_has_internet = (bool) $sock ? true : false;`
	`27`	`+ self::$_has_internet = (bool) $sock;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`return self::$_has_internet;`