Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Cobra/Viper #106

Open
Hu13er opened this issue Sep 26, 2019 · 1 comment
Open

Using Cobra/Viper #106

Hu13er opened this issue Sep 26, 2019 · 1 comment
Labels
2.0.0 enhancement New feature or request

Comments

@Hu13er
Copy link

Hu13er commented Sep 26, 2019

Hi...
i was reading the project and realized that parsing command line and configuration codes are in daemon/main.go file. How you think about separating daemon and project bootstrapping logic and use some packages like github.com/spf13/{cobra,viper}?
thanks

@kilgaloon
Copy link
Owner

Hello,

Thanks for you contribution. I reviewed Cobra and Viper and they seem like a good fit. But one thing regarding Viper is that if we wan't to implement it in order not to break backwards compatibility we will need to have our layer above Viper which will totally defeat purpose of Viper.

Also i don't mind increasing major version and start working on 2.0.0 but before that i would like to review couple more things which can be implemented in major version update

If you have more suggestions regarding this i'm open for discussion

@kilgaloon kilgaloon added enhancement New feature or request 2.0.0 labels Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants