Fix head field used by octokit.rest.pulls.list() method #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In octokit/rest 18 doc (https://octokit.github.io/rest.js/v18) there is explanation about octokit.rest.pulls.list and for the `head` field it mentions: "Filter pulls by head user or head organization and branch name in the format of user:ref-name or organization:ref-name. For example: github:new-script-format or octocat:test-branch." We are currently using user/fork-name:ref-name and from the documentation it seems it should be user:ref-name
baldimir
approved these changes
Mar 6, 2024
|
e2e-regression-cli tests are failing, investigating why... |
|
so those e2e-regression-cli tests are failing already and it is not related to my PR, see #465. I will merge this one for now and can look later on those test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In octokit/rest 18 doc (https://octokit.github.io/rest.js/v18) there is explanation about octokit.rest.pulls.list and for the
headfield it mentions:Filter pulls by head user or head organization and branch name in the format of user:ref-name or organization:ref-name. For example: github:new-script-format or octocat:test-branch.We are currently using user/fork-name:ref-name and from the documentation it seems it should be user:ref-name