Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[molecule] skip the OpenShift part of the test if not on OpenShift #845

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jmazzitelli
Copy link
Contributor

I tested on both minikube and openshift and all works now - molecule test now passes for both:

Minikube

./hack/k8s-minikube.sh start

./hack/k8s-minikube.sh istio 

./hack/run-molecule-tests.sh --client-exe "$(which kubectl)" -dorp podman --cluster-type minikube -at "remote-cluster-resources-test"

OpenShift

./hack/crc-openshift.sh start -p <path to your pull-secret.txt>

oc login -u kubeadmin -p kiali https://api.crc.testing:6443 --insecure-skip-tls-verify

./hack/istio/install-istio-via-istioctl.sh -cp openshift

./hack/run-molecule-tests.sh --client-exe "$(which oc)" -dorp podman --cluster-type openshift -at "remote-cluster-resources-test"

@jmazzitelli jmazzitelli self-assigned this Nov 12, 2024
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@jmazzitelli jmazzitelli merged commit c6d50c0 into kiali:master Nov 12, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the fix-molecule branch November 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants