Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include task has been deprecated in ansible - use include_tasks instead #821

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jmazzitelli
Copy link
Contributor

I don't know how this one sneaked through, but all others have already been replaced. This needs to be replaced, too.

This isn't necessary right now (so no need to backport) but this will be needed in the future when we get a new ansible operator base image that has Ansible 2.16+ in it. So let's get this in now.

I don't know how this one sneaked through, but all others have already been replaced. This needs to be replaced, too.
@jmazzitelli jmazzitelli self-assigned this Sep 21, 2024
Copy link
Collaborator

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but the change LGTM. The rest of the ansible files use include_tasks except these three files.

@jmazzitelli jmazzitelli merged commit 80388d6 into kiali:master Sep 23, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the ansible-deprecated-task branch September 23, 2024 12:23
@jshaughn jshaughn added the test: n/a PR does not need test additions or updates label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

3 participants