Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make long images fit width #524

Open
Groovin-Dev opened this issue Mar 7, 2025 · 3 comments
Open

Make long images fit width #524

Groovin-Dev opened this issue Mar 7, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@Groovin-Dev
Copy link

Long images, before a recent update, would fit width when you scrolled. While not the best way to do it at least it worked. After this recent update, long images now display with fit height and you can't properly zoom in.

I think long images should be fit width (by default, not only after scrolling) so you can actually view them.

I tried building on Windows to implement this myself but ran into far too many issues so decided to open a ticket.

@khoadng
Copy link
Owner

khoadng commented Mar 7, 2025

Fit width without scrolling won’t work because the image would be cropped. The new viewer separates the image and the information panel, so I can't enable scrolling for the image without causing gesture conflicts.

My solution is to fix zooming so that scrolling works while in zoom mode. I believe most gallery apps use this same design.

@Groovin-Dev
Copy link
Author

I didn't mean to remove scrolling I just meant have it fit width instantly. I updated to the latest version (I forget the number) but it was the one where you added Plus and that removed the thing where when you opened a long image and scrolled instead of opening the info panel it would zoom the image to fit width. I'm proposing that its fit width instantly and then the user can scroll to continue viewing the image and when its done you open the info panel. Perhaps have something where you can tap the image to then scroll down to view the info panel similar to how Mihon will display the full image and only when you tap does it show an overlay which is when you can exit viewing to prevent accidental exits. I think Boorusama would have to do it a little different to still allow for swiping left/right but having you tap IF you want to view the info panel half way through the image.

Sorry if my original post had confusing wording

@khoadng
Copy link
Owner

khoadng commented Mar 8, 2025

I see. I’ll give it more thought since it is a lot more involved, but first, i'll fix the zooming issue so long images display properly.

@khoadng khoadng added the enhancement New feature or request label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants