Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed detection of modded item groups in GUIs #295

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Fixed detection of modded item groups in GUIs #295

merged 8 commits into from
Jun 24, 2024

Conversation

TheSuperGamer20578
Copy link
Contributor

Changelog

New Features

Feature Updates

  • Added better naming for unknown (modded) item groups in GUIs

Bug Fixes

  • Fixed detection of unknown (modded) item groups in GUIs

Translation Changes

Others

Development Chores

boholder
boholder requested changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@boholder boholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my stupid, I can't understand some details in the PR, can you make the code more clear?

@TheSuperGamer20578
Copy link
Contributor Author

I've moved that condition to a boolean and fixed the one indentation error I could see. Short of adding a bunch of comments I don't think there is much I can do to make it clearer but I might be able to have a better look and think of something if I have another look when it's not late afternoon after a party.

@boholder
Copy link
Collaborator

Short of adding a bunch of comments I don't think there is much I can do to make it clearer

Use method naming, variable naming to describe the purpose of logic, instead of comments.
Only comment when you can't find a brief clear conclusion about the logic.

See https://github.com/FabricMC/yarn/blob/24w03b/CONVENTIONS.md

@boholder
Copy link
Collaborator

boholder commented Jun 23, 2024 •
edited
Loading

Some refactor FYI: https://github.com/boholder/minecraft-access/commits/modded-gui-groups/

The or() can be replaced with orElse() thus the result can be directly List without Optional wrapper

boholder
boholder approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@boholder boholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@boholder
Copy link
Collaborator

/fast-forward

@khanshoaib3
Copy link
Owner

[Fast Forward CI] modded-gui-groups merged into 1.20... Copied the changelogs from pull request body to doc/CHANGELOG.md... Pushed the changes to origin.

khanshoaib3 pushed a commit that referenced this pull request Jun 24, 2024
@actions-user
chore(ff ci): add changelogs from #295 to CHANGELOG.md
e9ae9f3
@khanshoaib3 khanshoaib3 merged commit 41d7a9c into khanshoaib3:1.20 Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boholder boholder boholder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheSuperGamer20578 @boholder @khanshoaib3