Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JEI (Just Enough Items), make its screen accessible #274

Open
boholder opened this issue Mar 4, 2024 · 1 comment
Open

Support JEI (Just Enough Items), make its screen accessible #274

boholder opened this issue Mar 4, 2024 · 1 comment
Labels
need-more-info haven't reproduct it in game, or the issue proposer needs to provide more information new-feature New functions

Comments

@boholder
Copy link
Collaborator

boholder commented Mar 4, 2024

I do believe that JEI (and REI (originally the JEI alternative on Fabric)) is the inspiration of the built-in Recipe Book feature, and it still better than the Recipe Book since it's supported by many third-party mods but mod's recipe won't be shown in the Recipe Book.

I do want to support it, but here are concerns:

  1. By searching Fabric Discord I know all I need to do is compileOnly two dependencies, will that dramatically increase the size of the build result?
  2. I can't use Mixin mechanism since the JEI isn't the original code, so HOW do I get to know enough information (how many items, how many categories, the position of every widget on the screen) to build a keyboard controller? Reflection is a bad idea since reflection codes can't automatically represent the changes of different version of original code (we do need to update the JEI version when upgrade to new game version).
  3. JEI is opened along with many screens, that will break the assumption "there is at most only one screen opened at a time". I think we can add a key combination to switch between the game screen and JEI screen, don't know if it works.

ref: https://github.com/mezz/JustEnoughItems/wiki/Getting-Started-%5BJEI-for-Minecraft-1.20.4--for-NeoForge,-Forge,-or-Fabric%5D#dependencies-for-loom-for-fabric

Maybe we can ask JEI devs for help, or figure out how to expose necessary values as public state.

@boholder boholder added new-feature New functions need-more-info haven't reproduct it in game, or the issue proposer needs to provide more information labels Mar 4, 2024
@boholder
Copy link
Collaborator Author

Presence Footsteps has optional dependency, check out how they achieve this.
https://modrinth.com/mod/presence-footsteps/version/1.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-more-info haven't reproduct it in game, or the issue proposer needs to provide more information new-feature New functions
Projects
None yet
Development

No branches or pull requests

1 participant