Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose args on SnakeBidsApp for plugins #264

Closed
pvandyken opened this issue Mar 13, 2023 · 0 comments · Fixed by #310
Closed

Expose args on SnakeBidsApp for plugins #264

pvandyken opened this issue Mar 13, 2023 · 0 comments · Fixed by #310
Assignees
@tkkuehn
Labels
enhancement New feature or request

Comments

@pvandyken
Copy link
Contributor

A simple change to improve plugin (#260) usability: right now run_snakemake has an internal args variable it uses for the parsed args. But we already have SnakeBidsApp.args, originally made for testing purposes, and it never gets set. Lets use that attribute instead, then plugins will get easy access to it (especially useful for plugins that expand the CLI)
@pvandyken pvandyken added the enhancement New feature or request label Mar 13, 2023
@tkkuehn tkkuehn self-assigned this Jun 2, 2023
@tkkuehn tkkuehn mentioned this issue Jun 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkkuehn tkkuehn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always set SnakeBidsApp.args in run_snakemake tkkuehn/snakebids
2 participants
@tkkuehn @pvandyken