Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #3

Open
Lord-Y opened this issue Sep 19, 2014 · 1 comment
Open

Improvements #3

Lord-Y opened this issue Sep 19, 2014 · 1 comment

Comments

@Lord-Y
Copy link

Lord-Y commented Sep 19, 2014

Hi,

Some improvement can be done:
shift $((OPTIND-1)) is missing after getops in fio.sh

default binary must be: BINARY="/usr/bin/fio" or which fio
line 688: offset ==> offsets
@khailey-zz
Copy link
Owner

thanks for the improvements.
I changed offet to offsets at line 687
and changed the default binary from ./fio to which fio
...
What does shift $((OPTIND-1)) gives me as I don' t use any values after the command line options are parsed?
Thanks
Kyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khailey-zz @Lord-Y