Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing expected output from RMLTC0004b-* test-cases? #53

Open
dachafra opened this issue Sep 30, 2021 · 3 comments
Open

Removing expected output from RMLTC0004b-* test-cases? #53

dachafra opened this issue Sep 30, 2021 · 3 comments

Comments

@dachafra
Copy link
Member

All of them have

Error expected: Yes
Expected knowledge graph: None, because an error is expected that stops the generation.
@DylanVanAssche
Copy link
Contributor

I think this is a bigger problem...
IMO we need proper defined errors in the spec as well that are returned.

For example:

  • Mapping rules invalid: return -1
  • Data error: return -2
  • ...

Of course with proper semantics ;)

The idea would be that you can always expect that an engine either returns triples or exits with a defined error code.

@dachafra
Copy link
Member Author

dachafra commented Sep 30, 2021

Could be for the future, but at this moment we have certain confusion with these test-cases as they provide the output file in Github but following the spec they shouldn't, so a way to solve it now could be removing these files.

@DylanVanAssche
Copy link
Contributor

@dachafra agreed.
It should be the same the R2RML ones are the RML ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants