Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 9 and Usefulness of nested fields. #25

Closed
tirrolo opened this issue May 29, 2024 · 1 comment · Fixed by #33
Closed

Example 9 and Usefulness of nested fields. #25

tirrolo opened this issue May 29, 2024 · 1 comment · Fixed by #33

Comments

@tirrolo
Copy link
Contributor

tirrolo commented May 29, 2024

Example 9 is not complete, as the weight is not rendered as a field. Furthermore, is it necessary to create a field for "Item"? We think it just adds confusion. Related to this: is nesting in fields really necessary?

@pmaria
Copy link
Collaborator

pmaria commented May 29, 2024

Example 9 is not complete, as the weight is not rendered as a field.

Indeed, this should be added.

Furthermore, is it necessary to create a field for "Item"? We think it just adds confusion. Related to this: is nesting in fields really necessary?

The nesting is indeed necessary. Without the nesting we will get a Cartesian product of the types and weights for items. This is precisely one of the use cases for fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants