This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
feat: use correct pkg manager when creating keystone app #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamandrewluca
commented
Jan 13, 2024
Comment on lines
+50
to
+55
| function pkgManagerFromUserAgent(userAgent: string | undefined) { | ||
| if (!userAgent) return 'npm'; | ||
| const pkgSpec = userAgent.split(' ')[0]; | ||
| const [name, _version] = pkgSpec.split('/'); | ||
| return name ?? 'npm'; | ||
| } |
There was a problem hiding this comment.
|
Hi @iamandrewluca, |
|
Hey @dcousens, I understand the pain of keeping it up to date. I'm here if you need any help from my side. |
|
Hey @dcousens, taking into consideration what you said about e.g. @keystone-6/[email protected] |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on what package manager tools were used, that package manager will be used.
Below package managers were tested, and are working:
Closes #413